Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add frontend cache query params #5775

Merged
merged 3 commits into from
Nov 26, 2020
Merged

feat: Add frontend cache query params #5775

merged 3 commits into from
Nov 26, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Nov 26, 2020 •
edited
Loading

No description provided.

@vercel
Copy link

vercel bot commented Nov 26, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/hwbfhsf79
✅ Preview: https://open-event-frontend-git-fp-cache.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #5775 (2a29974) into development (df1d513) will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5775      +/-   ##
===============================================
+ Coverage        23.40%   23.45%   +0.04%     
===============================================
  Files              513      512       -1     
  Lines             5481     5445      -36     
  Branches            62       63       +1     
===============================================
- Hits              1283     1277       -6     
+ Misses            4182     4152      -30     
  Partials            16       16
Impacted Files Coverage Δ
app/routes/application.js 83.33% <ø> (-0.46%) ⬇️
app/routes/index.js 78.57% <ø> (ø)
app/services/cache.ts 61.40% <50.00%> (-2.75%) ⬇️
app/adapters/application.js 88.00% <83.33%> (-1.48%) ⬇️
app/components/footer-main.js 66.66% <100.00%> (ø)
app/services/settings.js 66.66% <100.00%> (ø)
app/models/event.js 50.00% <0.00%> (ø)
app/models/session.js 10.00% <0.00%> (ø)
app/models/speaker.js 0.00% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d513...790ce1a. Read the comment docs.

@iamareebjamal iamareebjamal merged commit bf9cbee into fossasia:development Nov 26, 2020
@iamareebjamal iamareebjamal deleted the fp-cache branch November 26, 2020 13:32
This was referenced Dec 2, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamareebjamal